Re: [PATCH 0/3] PCI: brcmstb: Add Broadcom STB support

[Jaedon Shin <jaedon.shin@xxxxxxxxx>]

> 2020. 2. 14. 오전 12:54, Jim Quinlan <james.quinlan@xxxxxxxxxxxx> 작성:
> 
> On Thu, Feb 13, 2020 at 12:15 AM Jaedon Shin <jaedon.shin@xxxxxxxxx> wrote:
>> 
>> 
>>> 2020. 2. 13. 오후 12:54, Florian Fainelli <f.fainelli@xxxxxxxxx> 작성:
>>> 
>>> +Jim,
>>> 
>>> On 2/12/2020 6:59 PM, Jaedon Shin wrote:
>>>> This series enables the ARM based Broadcom STB SoCs and supports GPIO
>>>> based regulators for its power supplies. and this has an improvement on
>>>> devm_ APIS.
>>> 
>>> Which ARM-based SoCs did you try this on? We still have an issue with
>>> the multiple dma-ranges that must be handled to support 7445 with memory
>>> in the extension regions as well as 7278 and 7216.
>> 
>> 
>> I'm using BCM72604 which has only one memc. and device is Qualcomm Atheros
>> QCA6174 Wi-Fi module.
>> 
> You apparently have a simple enough memory configuration such that the
> current upstream driver will work.  But this will not work for a
> 7445-based chip or other BCM7xxx chips that either have a memory
> region extension or a non-zero system memory offset.

I fully agree. It's not yet ready to enable ARM based BCM7445 SoCs. We'd better
not add ARCH_BRCMSTB and "brcm,bcm7445-pcie" string until the multi dma-
range problem is solved.

> 
> IIRC, similar regulator code was submitted before as part of the
> complete driver that could handle our curious DMA situation, but was
> rejected because someone objected to us using a  generic list of
> regulators without specific explanation for each in the device tree
> documentations.  I hope you have better luck :-)

I'll refer to.

Thanks,
Jaedon

> 
> Thanks,
> Jim
>>> 
>>> See comments in specific patches.
>>> 
>>>> 
>>>> Jaedon Shin (3):
>>>> PCI: brcmstb: Enable ARCH_BRCMSTB
>>>> PCI: brcmstb: Add regulator support
>>>> PCI: brcmstb: Drop clk_put when probe fails and remove
>>>> 
>>>> .../bindings/pci/brcm,stb-pcie.yaml           |  8 +-
>>>> drivers/gpio/gpio-brcmstb.c                   | 13 +++-
>>>> drivers/pci/controller/Kconfig                |  2 +-
>>>> drivers/pci/controller/pcie-brcmstb.c         | 78 ++++++++++++++++++-
>>>> 4 files changed, 97 insertions(+), 4 deletions(-)
>>>> 
>>> 
>>> --
>>> Florian