On Tue, Jan 14, 2020 at 9:39 AM Kevin Hao <haokexin@xxxxxxxxx> wrote: > Since the commit a7fc89f9d5fc ("gpio: thunderx: Switch to > GPIOLIB_IRQCHIP"), the thunderx gpio doesn't work anymore. I noticed > that you have submitted a patch [1] to fix the " irq_domain_push_irq: -22" > error, but the kernel would panic after applying that fix because the hwirq > passed to the msi irqdomain is still not correct. It seems that we need > more codes to make the thunderx gpio work with the GPIOLIB_IRQCHIP. So I > would prefer to revert the commit a7fc89f9d5fc first to make the thunderx > gpio to work on the 5.4.x and 5.5 at least. We can then do more test for > GPIOLIB_IRQCHIP switching (which the patch 2 ~ 4 do) before merging > them. Thanks a LOT Kevin, and I'm sorry for open coding and breaking this driver so much :/ I have applied all four patches for fixes. Yours, Linus Walleij