Le 27/11/2019 à 14:56, Linus Walleij a écrit :
On Wed, Nov 27, 2019 at 2:54 PM Christophe Leroy
<christophe.leroy@xxxxxx> wrote:
Le 27/11/2019 à 14:52, Linus Walleij a écrit :
On Wed, Nov 27, 2019 at 2:45 PM Christophe Leroy
<christophe.leroy@xxxxxx> wrote:
Le 27/11/2019 à 14:00, Linus Walleij a écrit :
Try to remove the "spi-cs-high" bool flag from your nodes,
because it seems like the old code was ignoring them.
Does that solve the problem?
Yes it does. Many thanks. I let you manage the packaging of fixes.
OK I will send a final batch of 3 patches fixing this.
Do you have these old device trees deployed so that we
also need to make sure that old device trees that have this
ambigous syntax will force precendence for the flag on the
GPIO line if both are specified for the "fsl,spi" instances?
No, we deliver device trees together with Linux kernel (embedded in an
Uboot ITS/ITB image) so no worry on old device trees.
OK thanks!
I sent three patches, can you apply them on a clean tree
and confirm it solves the problem (fingers crossed...)
Thanks a lot for helping me fix this!
The series is OK if using 'cs-gpios'.
With 'gpios' in the DTS, I get:
[ 3.154747] fsl_spi ff000a80.spi: cs1 >= max 1
[ 3.159207] spi_master spi0: spi_device register error
/soc@ff000000/cpm@9c0/spi@a80/lm74@1
[ 3.167344] spi_master spi0: Failed to create SPI device for
/soc@ff000000/cpm@9c0/spi@a80/lm74@1
[ 3.176303] fsl_spi ff000a80.spi: cs2 >= max 1
[ 3.180626] spi_master spi0: spi_device register error
/soc@ff000000/cpm@9c0/spi@a80/sicofi_gw@2
[ 3.189329] spi_master spi0: Failed to create SPI device for
/soc@ff000000/cpm@9c0/spi@a80/sicofi_gw@2
[ 3.198574] fsl_spi ff000a80.spi: cs3 >= max 1
[ 3.202788] spi_master spi0: spi_device register error
/soc@ff000000/cpm@9c0/spi@a80/eeprom@3
[ 3.211364] spi_master spi0: Failed to create SPI device for
/soc@ff000000/cpm@9c0/spi@a80/eeprom@3
[ 3.220361] fsl_spi ff000a80.spi: cs4 >= max 1
[ 3.224561] spi_master spi0: spi_device register error
/soc@ff000000/cpm@9c0/spi@a80/sicofi@4
[ 3.233137] spi_master spi0: Failed to create SPI device for
/soc@ff000000/cpm@9c0/spi@a80/sicofi@4
[ 3.242120] fsl_spi ff000a80.spi: cs5 >= max 1
[ 3.246336] spi_master spi0: spi_device register error
/soc@ff000000/cpm@9c0/spi@a80/lm74@5
[ 3.254740] spi_master spi0: Failed to create SPI device for
/soc@ff000000/cpm@9c0/spi@a80/lm74@5
[ 3.263552] fsl_spi ff000a80.spi: cs6 >= max 1
[ 3.267764] spi_master spi0: spi_device register error
/soc@ff000000/cpm@9c0/spi@a80/eeprom@6
[ 3.276342] spi_master spi0: Failed to create SPI device for
/soc@ff000000/cpm@9c0/spi@a80/eeprom@6
[ 3.285328] fsl_spi ff000a80.spi: cs7 >= max 1
[ 3.289667] spi_master spi0: spi_device register error
/soc@ff000000/cpm@9c0/spi@a80/csfavgw@7
[ 3.298070] spi_master spi0: Failed to create SPI device for
/soc@ff000000/cpm@9c0/spi@a80/csfavgw@7
Christophe
