Re: [PATCH] gpiolib: acpi: Print pin number on acpi_gpiochip_alloc_event errors

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

On 21-10-2019 15:23, Andy Shevchenko wrote:
On Mon, Oct 21, 2019 at 02:52:13PM +0200, Hans de Goede wrote:
On 21-10-2019 11:11, Andy Shevchenko wrote:
On Fri, Oct 18, 2019 at 09:52:08PM +0200, Hans de Goede wrote:
Print pin number on acpi_gpiochip_alloc_event errors, to help debugging
these.

I'm not sure which one is better decimal or hex, perhaps Mika can help me, in any case

They are listed as hex in the dis-assembled DSTD.

Oh, now I noticed the potential issue. The pin can be 16-bit, you pring here
only for the case when we have evname. Maybe do something similar in these
messages? Print event name for pin inside byte range and value otherwise?

I'm preparing a v2 now, together with another related, less cosmetic patch.
I will switch to a 16 bit printf format for v2.

Regards,

Hans





[Index of Archives]     [Linux SPI]     [Linux Kernel]     [Linux ARM (vger)]     [Linux ARM MSM]     [Linux Omap]     [Linux Arm]     [Linux Tegra]     [Fedora ARM]     [Linux for Samsung SOC]     [eCos]     [Linux Fastboot]     [Gcc Help]     [Git]     [DCCP]     [IETF Announce]     [Security]     [Linux MIPS]     [Yosemite Campsites]

  Powered by Linux