Hi,
On 21-10-2019 11:11, Andy Shevchenko wrote:
On Fri, Oct 18, 2019 at 09:52:08PM +0200, Hans de Goede wrote:
Print pin number on acpi_gpiochip_alloc_event errors, to help debugging
these.
I'm not sure which one is better decimal or hex, perhaps Mika can help me, in any case
They are listed as hex in the dis-assembled DSTD.
Regards,
Hans
Reviewed-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
Signed-off-by: Hans de Goede <hdegoede@xxxxxxxxxx>
---
drivers/gpio/gpiolib-acpi.c | 9 ++++++---
1 file changed, 6 insertions(+), 3 deletions(-)
diff --git a/drivers/gpio/gpiolib-acpi.c b/drivers/gpio/gpiolib-acpi.c
index 609ed16ae933..2911dd6f2625 100644
--- a/drivers/gpio/gpiolib-acpi.c
+++ b/drivers/gpio/gpiolib-acpi.c
@@ -230,19 +230,22 @@ static acpi_status acpi_gpiochip_alloc_event(struct acpi_resource *ares,
desc = gpiochip_request_own_desc(chip, pin, "ACPI:Event",
GPIO_ACTIVE_HIGH, GPIOD_IN);
if (IS_ERR(desc)) {
- dev_err(chip->parent, "Failed to request GPIO\n");
+ dev_err(chip->parent,
+ "Failed to request GPIO for pin 0x%02X\n", pin);
return AE_ERROR;
}
ret = gpiochip_lock_as_irq(chip, pin);
if (ret) {
- dev_err(chip->parent, "Failed to lock GPIO as interrupt\n");
+ dev_err(chip->parent,
+ "Failed to lock GPIO pin 0x%02X as interrupt\n", pin);
goto fail_free_desc;
}
irq = gpiod_to_irq(desc);
if (irq < 0) {
- dev_err(chip->parent, "Failed to translate GPIO to IRQ\n");
+ dev_err(chip->parent,
+ "Failed to translate GPIO pin 0x%02X to IRQ\n", pin);
goto fail_unlock_irq;
}
--
2.23.0
