Re: [PATCH] gpio: pca953x: Add Maxim MAX7313 PWM support

[Miquel Raynal <miquel.raynal@xxxxxxxxxxx>]

Hi Andy,

Andy Shevchenko <andy.shevchenko@xxxxxxxxx> wrote on Tue, 5 Nov 2019
11:08:39 +0200:

> On Tue, Nov 5, 2019 at 11:02 AM Miquel Raynal <miquel.raynal@xxxxxxxxxxx> wrote:
> > Andy Shevchenko <andy.shevchenko@xxxxxxxxx> wrote on Tue, 5 Nov 2019
> > 09:06:37 +0200:  
> > > On Mon, Nov 4, 2019 at 10:33 PM Uwe Kleine-König
> > > <u.kleine-koenig@xxxxxxxxxxxxxx> wrote:  
> 
> > > For me it sounds more likely that PWM is a *pin function* of a pin
> > > controller and actually this GPIO driver should be a pin controller
> > > with corresponding function(s).
> > >  
> >
> > Ok, thanks for the input, I will address Thierry's comments and
> > re-submit as a single file (same shape as in v1).  
> 
> Perhaps I have to be more clear. What I meant is that pin control
> should support PWM pin function and PCA953x be converted to a pin
> control + GPIO + PWM.
> Above definitely is not what you did and it's not for immediate submission.

Sorry for the misunderstanding, I was answering Uwe.

> I really would like to hear if it makes sense.

While this would probably be the nicest and cleanest solution, I don't
think it is doable in a reasonable amount of time compared to the
benefits.


Thanks,
Miquèl