pinctrl regresssion on mx28

[Fabio Estevam <festevam@xxxxxxxxx>]

Hi,

I noticed that on a imx28-evk running kernel 5.3.6 the following
pinctrl error is seen:

[    3.758280] imx28-pinctrl 80018000.pinctrl: not freeing pin 24
(GPMI_RDN) as part of deactivating group gpmi-nand.0 - it is already
used for some other setting
[    3.773300] imx28-pinctrl 80018000.pinctrl: not freeing pin 25
(GPMI_WRN) as part of deactivating group gpmi-nand.0 - it is already
used for some other setting
[    3.787913] imx28-pinctrl 80018000.pinctrl: not freeing pin 28
(GPMI_RESETN) as part of

Looking at imx28-evk.dts we have the following for the GPMI NAND pins setup:

gpmi-nand@8000c000 {
pinctrl-names = "default";
pinctrl-0 = <&gpmi_pins_a &gpmi_status_cfg
     &gpmi_pins_evk>;
status = "okay";
};

GPMI_RDN, GPMI_WRN and GPMI_RESETN all come from the common
gpmi_pins_a group (defined at imx28.dtsi) and are then overwritten by
the gpmi_status_cfg group with a different drive strength.

This worked in the past, but no longer working with 5.3.x

If I manually change the dts like this:
http://code.bulix.org/n9350k-914661

so that these pins are only defined once, then the NAND flash is
properly detected:

[    3.752437] nand: device found, Manufacturer ID: 0x2c, Chip ID: 0xd5
[    3.759142] nand: Micron MT29F32G08QAA
[    3.762992] nand: 2048 MiB, MLC, erase size: 512 KiB, page size:
4096, OOB size: 218
[    3.802073] gpmi-nand 8000c000.gpmi-nand: driver registered.

As we don't want to break old dtb's, what would be the correct fix for
this issue?

Thanks