Re: drivers/pinctrl/sh-pfc/pfc-sh7734.c multiple define of TCLK1_B

[Geert Uytterhoeven <geert@xxxxxxxxxxxxxx>]

Hi Ben,

On Thu, Oct 17, 2019 at 1:54 PM Ben Dooks <ben.dooks@xxxxxxxxxxxxxxx> wrote:
> drivers/pinctrl/sh-pfc/pfc-sh7734.c hsa TCLK1_B defined twice.
> Not sure how to fix, so reporting it here:
>
>    1453          GPIO_FN(RD_WR), GPIO_FN(TCLK1_B),
>    1454          GPIO_FN(EX_WAIT0), GPIO_FN(TCLK1_B),

Thanks, nice catch!

Looks like (a) someone accidentally jumped to the wrong row in the
datasheet when entering this, and (b) we need more runtime checks to
catch bugs like this.

Will fix...

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds