Hi,
On 10-10-2019 09:26, Andy Shevchenko wrote:
On Thu, Oct 10, 2019 at 10:23:04AM +0300, Andy Shevchenko wrote:
On Wed, Oct 09, 2019 at 09:44:31PM +0200, Hans de Goede wrote:
On 09-10-2019 18:50, Andy Shevchenko wrote:
After changing the drivers to use GPIO core to add an IRQ chip
it appears that some of them requires a hardware initialization
before adding the IRQ chip.
Add an optional callback ->init_hw() to allow that drivers
to initialize hardware if needed.
This change is a part of the fix NULL pointer dereference
brought to the several drivers recently.
Cc: Hans de Goede <hdegoede@xxxxxxxxxx>
Signed-off-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
Hmm, IIRC Linus Walleij already added a callback for initializing the
mask before the irchip gets initialized which is basically intended for
what you want this callback for I think ?
This is not about the mask, it's about hardware to be prepared before enabling.
Also init_valid_mask() will allocate memory which won't be needed.
If you think this is not a proper approach, we have to revert all three patches
now (*) and think about better solution.
If this is not about the valid-mask then this approach is probably fine,
sorry for the confusion. Lets wait and see what Linus Walleij has to say.
Regards,
Hans
