Re: [PATCH 2/5] gpiolib: Initialize the hardware with a callback

[Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>]

On Wed, Oct 09, 2019 at 09:44:31PM +0200, Hans de Goede wrote:
> On 09-10-2019 18:50, Andy Shevchenko wrote:
> > After changing the drivers to use GPIO core to add an IRQ chip
> > it appears that some of them requires a hardware initialization
> > before adding the IRQ chip.
> > 
> > Add an optional callback ->init_hw() to allow that drivers
> > to initialize hardware if needed.
> > 
> > This change is a part of the fix NULL pointer dereference
> > brought to the several drivers recently.
> > 
> > Cc: Hans de Goede <hdegoede@xxxxxxxxxx>
> > Signed-off-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
> 
> Hmm, IIRC Linus Walleij already added a callback for initializing the
> mask before the irchip gets initialized which is basically intended for
> what you want this callback for I think ?

This is not about the mask, it's about hardware to be prepared before enabling.
Also init_valid_mask() will allocate memory which won't be needed.

-- 
With Best Regards,
Andy Shevchenko