Hi YueHaibing, thanks, Acked-by: Eugeniy Paltsev <Eugeniy.Paltsev@xxxxxxxxxxxx> --- Eugeniy Paltsev ________________________________________ From: YueHaibing <yuehaibing@xxxxxxxxxx> Sent: Friday, September 6, 2019 16:10 To: Eugeniy.Paltsev@xxxxxxxxxxxx; linus.walleij@xxxxxxxxxx; bgolaszewski@xxxxxxxxxxxx Cc: linux-gpio@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; kernel-janitors@xxxxxxxxxxxxxxx; YueHaibing Subject: [PATCH -next] gpio: creg-snps: use devm_platform_ioremap_resource() to simplify code Use devm_platform_ioremap_resource() to simplify the code a bit. This is detected by coccinelle. Signed-off-by: YueHaibing <yuehaibing@xxxxxxxxxx> --- drivers/gpio/gpio-creg-snps.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/gpio/gpio-creg-snps.c b/drivers/gpio/gpio-creg-snps.c index 8cbc94d..ff19a8a 100644 --- a/drivers/gpio/gpio-creg-snps.c +++ b/drivers/gpio/gpio-creg-snps.c @@ -137,7 +137,6 @@ static int creg_gpio_probe(struct platform_device *pdev) const struct of_device_id *match; struct device *dev = &pdev->dev; struct creg_gpio *hcg; - struct resource *mem; u32 ngpios; int ret; @@ -145,8 +144,7 @@ static int creg_gpio_probe(struct platform_device *pdev) if (!hcg) return -ENOMEM; - mem = platform_get_resource(pdev, IORESOURCE_MEM, 0); - hcg->regs = devm_ioremap_resource(dev, mem); + hcg->regs = devm_platform_ioremap_resource(pdev, 0); if (IS_ERR(hcg->regs)) return PTR_ERR(hcg->regs); -- 2.7.4