On Fri, Sep 06, 2019 at 05:26:01PM +0200, Arnd Bergmann wrote: > The intel_pin_to_gpio() function is only called by the > PM support functions and causes a warning when those are disabled: > > drivers/pinctrl/intel/pinctrl-intel.c:841:12: error: unused function 'intel_pin_to_gpio' [-Werror,-Wunused-function] > > As we cannot change the PM functions themselves to use __maybe_unused, > add another #ifdef here for consistency. It's not adding another #ifdef here... Nevertheless, I'm afraid that in the future we might need this in other place(s). Can we add __maybe_unused to this function exclusively? -- With Best Regards, Andy Shevchenko
Re: [PATCH] pinctrl: intel: hide unused intel_pin_to_gpio
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
- Subject: Re: [PATCH] pinctrl: intel: hide unused intel_pin_to_gpio
- From: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
- Date: Fri, 6 Sep 2019 19:59:32 +0300
- In-reply-to: <20190906152609.1603386-1-arnd@arndb.de>
- Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo
- References: <20190906152609.1603386-1-arnd@arndb.de>
- User-agent: Mutt/1.10.1 (2018-07-13)
- Follow-Ups:
- Re: [PATCH] pinctrl: intel: hide unused intel_pin_to_gpio
- From: Arnd Bergmann
- Re: [PATCH] pinctrl: intel: hide unused intel_pin_to_gpio
- References:
- [PATCH] pinctrl: intel: hide unused intel_pin_to_gpio
- From: Arnd Bergmann
- [PATCH] pinctrl: intel: hide unused intel_pin_to_gpio
- Prev by Date: [PATCH] pinctrl: intel: hide unused intel_pin_to_gpio
- Next by Date: Re: [PATCH -next] gpio: creg-snps: use devm_platform_ioremap_resource() to simplify code
- Previous by thread: [PATCH] pinctrl: intel: hide unused intel_pin_to_gpio
- Next by thread: Re: [PATCH] pinctrl: intel: hide unused intel_pin_to_gpio
- Index(es):
 |