On Thu, Aug 15, 2019 at 8:07 AM Nishka Dasgupta <nishkadg.linux@xxxxxxxxx> wrote: > Each iteration of for_each_child_of_node puts the previous node, but in > the case of a return from the middle of the loop, there is no put, thus > causing a memory leak. Hence add an of_node_put before the return. > Issue found with Coccinelle. > > Signed-off-by: Nishka Dasgupta <nishkadg.linux@xxxxxxxxx> Patch applied with Neil's ACK. Yours, Linus Walleij
Re: [PATCH] pinctrl: meson: meson: Add of_node_put() before return
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
- Subject: Re: [PATCH] pinctrl: meson: meson: Add of_node_put() before return
- From: Linus Walleij <linus.walleij@xxxxxxxxxx>
- Date: Fri, 23 Aug 2019 11:48:46 +0200
- In-reply-to: <20190815060718.3286-1-nishkadg.linux@gmail.com>
- References: <20190815060718.3286-1-nishkadg.linux@gmail.com>
- References:
- [PATCH] pinctrl: meson: meson: Add of_node_put() before return
- From: Nishka Dasgupta
- [PATCH] pinctrl: meson: meson: Add of_node_put() before return
- Prev by Date: Re: [PATCH] gpio: Fix irqchip initialization order
- Next by Date: Re: [PATCH] pinctrl: bcm2835: Pass irqchip when adding gpiochip
- Previous by thread: Re: [PATCH] pinctrl: meson: meson: Add of_node_put() before return
- Next by thread: [PATCH] pinctrl: samsung: samsung: Add of_node_put() before return
- Index(es):
 |