Re: [PATCH] pinctrl: sprd: Add of_node_put() before return to prevent memory leak

[Linus Walleij <linus.walleij@xxxxxxxxxx>]

On Thu, Aug 8, 2019 at 9:43 AM Nishka Dasgupta <nishkadg.linux@xxxxxxxxx> wrote:

> Each iteration of for_each_child_of_node puts the previous node, but in
> the case of a return from the middle of the loop, there is no put, thus
> causing a memory leak. Hence add an of_node_put before the return in
> two places.
> Issue found with Coccinelle.
>
> Signed-off-by: Nishka Dasgupta <nishkadg.linux@xxxxxxxxx>

Patch applied with Baolin's review tag.

Yours,
Linus Walleij