Re: [PATCH v1] pinctrl: intel: Use NSEC_PER_USEC for debounce calculus

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Aug 06, 2019 at 01:14:12PM +0300, Mika Westerberg wrote:
> On Tue, Jul 23, 2019 at 06:54:31PM +0300, Andy Shevchenko wrote:
> > Replace hard coded constants with self-explanatory names, i.e.
> > use NSEC_PER_USEC for debounce calculus.
> > 
> > While here, add a unit suffix to debounce period constant.

> > -#define DEBOUNCE_PERIOD			31250 /* ns */
> > +#define DEBOUNCE_PERIOD_NS		31250
> 
> Should this be called DEBOUNCE_PERIOD_NSEC to be consistent with
> NSEC_PER_USEC?

Either will good look to me.

> Otherwise looks good.

Will fix for v2.

Thanks!

-- 
With Best Regards,
Andy Shevchenko





[Index of Archives]     [Linux SPI]     [Linux Kernel]     [Linux ARM (vger)]     [Linux ARM MSM]     [Linux Omap]     [Linux Arm]     [Linux Tegra]     [Fedora ARM]     [Linux for Samsung SOC]     [eCos]     [Linux Fastboot]     [Gcc Help]     [Git]     [DCCP]     [IETF Announce]     [Security]     [Linux MIPS]     [Yosemite Campsites]

  Powered by Linux