Re: [PATCH] pinctrl: aspeed: Strip moved macros and structs from private header

[Linus Walleij <linus.walleij@xxxxxxxxxx>]

On Wed, Jul 10, 2019 at 5:22 AM Andrew Jeffery <andrew@xxxxxxxx> wrote:

> Further cleanup from the SPDX fixup fallout for the recent ASPEED
> series. aspeed_g4_defconfig, aspeed_g5_defconfig and multi_v5_defconfig
> now compile. Smoke tested the g4 and g5 kernels under QEMU's
> palmetto-bmc and romulus-bmc machines respectively.
>
> Fixes: 35d8510ea3ad ("pinctrl: aspeed: Fix missed include")
> Signed-off-by: Andrew Jeffery <andrew@xxxxxxxx>
> ---
>
> Sorry Linus, I guess I should have just sent the fixup patch rather than
> waiting for your response about which way to handle the break. That way I would
> have actually fixed the problem rather than just eyeballing it and making
> half-baked suggestions.
>
> The content stripped in this patch was moved to aspeed-pinmux.h, so with
> 35d8510ea3ad ("pinctrl: aspeed: Fix missed include") we hit
> duplicate-declaration problems. Trivially resolved by removing the moved
> content.

I applied it and now it compiles so I'm happy :)

There was inevitably going to be some fallout from the SPDX stuff
in this merge window, but tglx has me convinced that it is worth
the effort and merge mess, so we just hash it out and carry on.

Yours,
Linus Walleij