On Tue, Jun 25, 2019 at 09:10:25AM +0200, Bartosz Golaszewski wrote: > pon., 24 cze 2019 o 20:22 Enrico Weigelt, metux IT consult > <lkml@xxxxxxxxx> napisał(a): > > > > On 24.06.19 12:46, Bartosz Golaszewski wrote: > > > > >> The patch seems pretty trivial and doesn't change any actual code, so > > >> I don't see hard resons for rejecting it. > > >> > > > > > > In its current form it makes the code even less readable. The #ifdef > > > should actually be one line lower and touch the comment instead of the > > > EXPORT_SYMBOL() related to a different function. > > > > Okay, that missing newline should be fixed (as well as the extra one > > after the #ifdef). Besides that, I don't see any further problems. > > > > Are we sure this even changes something? Does kernel documentation get > generated according to current config options? I really think this > patch just pollutes the history for now apparent reason. > > Greg, could you give your opinion on this? Why are you all arguing with a all-but-instinguishable-from-a-bot persona about a patch that I will never apply? greg k-h