On 24.06.19 12:46, Bartosz Golaszewski wrote: >> The patch seems pretty trivial and doesn't change any actual code, so >> I don't see hard resons for rejecting it. >> > > In its current form it makes the code even less readable. The #ifdef > should actually be one line lower and touch the comment instead of the > EXPORT_SYMBOL() related to a different function. Okay, that missing newline should be fixed (as well as the extra one after the #ifdef). Besides that, I don't see any further problems. --mtx -- Enrico Weigelt, metux IT consult Free software and Linux embedded engineering info@xxxxxxxxx -- +49-151-27565287
Re: [PATCH] drivers: Adjust scope for CONFIG_HAS_IOMEM before devm_platform_ioremap_resource()
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
- Subject: Re: [PATCH] drivers: Adjust scope for CONFIG_HAS_IOMEM before devm_platform_ioremap_resource()
- From: "Enrico Weigelt, metux IT consult" <lkml@xxxxxxxxx>
- Date: Mon, 24 Jun 2019 20:22:45 +0200
- In-reply-to: <CAMRc=McepqowJNi6ay6x9KKoHOC8aCxP_ob12SgbsnJU_sKQng@mail.gmail.com>
- Organization: metux IT consult
- References: <20190221162627.3476-1-brgl@bgdev.pl> <9efcbce2-4d49-7197-a3d8-0e83850892d5@web.de> <CAMpxmJX-wXQ-ff1RWkPmJBWSsP_v2MjZrA3fhj3HQX0_zM0eZA@mail.gmail.com> <39ae399a-c606-c6de-f84d-35e39d0410c0@metux.net> <CAMRc=McepqowJNi6ay6x9KKoHOC8aCxP_ob12SgbsnJU_sKQng@mail.gmail.com>
- User-agent: Mozilla/5.0 (X11; Linux i686 on x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.2.1
- Follow-Ups:
- Re: [PATCH] drivers: Adjust scope for CONFIG_HAS_IOMEM before devm_platform_ioremap_resource()
- From: Bartosz Golaszewski
- Re: [PATCH] drivers: Adjust scope for CONFIG_HAS_IOMEM before devm_platform_ioremap_resource()
- References:
- [PATCH] drivers: depend on HAS_IOMEM for devm_platform_ioremap_resource()
- From: Bartosz Golaszewski
- [PATCH] drivers: Adjust scope for CONFIG_HAS_IOMEM before devm_platform_ioremap_resource()
- From: Markus Elfring
- Re: [PATCH] drivers: Adjust scope for CONFIG_HAS_IOMEM before devm_platform_ioremap_resource()
- From: Bartosz Golaszewski
- Re: [PATCH] drivers: Adjust scope for CONFIG_HAS_IOMEM before devm_platform_ioremap_resource()
- From: Enrico Weigelt, metux IT consult
- Re: [PATCH] drivers: Adjust scope for CONFIG_HAS_IOMEM before devm_platform_ioremap_resource()
- From: Bartosz Golaszewski
- [PATCH] drivers: depend on HAS_IOMEM for devm_platform_ioremap_resource()
- Prev by Date: Re: [PATCH V4 02/18] pinctrl: tegra: add suspend and resume support
- Next by Date: Re: [RFC] Addition of kernel
- Previous by thread: Re: drivers: Adjust scope for CONFIG_HAS_IOMEM before devm_platform_ioremap_resource()
- Next by thread: Re: [PATCH] drivers: Adjust scope for CONFIG_HAS_IOMEM before devm_platform_ioremap_resource()
- Index(es):
 |