Re: [PATCH v2 2/7] gpiolib: Make use of enum gpio_lookup_flags consistent

[Mika Westerberg <mika.westerberg@xxxxxxxxxxxxxxx>]

On Thu, Apr 11, 2019 at 03:00:23PM +0300, Andy Shevchenko wrote:
> On Thu, Apr 11, 2019 at 01:37:55PM +0300, Mika Westerberg wrote:
> > On Thu, Apr 11, 2019 at 12:58:48PM +0300, Andy Shevchenko wrote:
> > > > > +acpi_gpiochip_parse_own_gpio(struct acpi_gpio_chip *achip,
> > > > > +			     struct fwnode_handle *fwnode,
> > > > > +			     const char **name,
> > > > > +			     unsigned long *lflags,
> > > > > +			     unsigned int *dflags)
> > > > 
> > > > Why not "unsigned int"? Now it looks inconsistent.
> > > 
> > > inconsistent with what part?
> > 
> > Now you have:
> > 
> >    unsigned long *lflags
> >    unsigned int *dflags
> > 
> > why not
> > 
> >    unsigned int *lflags
> >    unsigned int *dflags
> > 
> > ?
> 
> Have you looked at the patch 4 in the series?

Actually I did not.

> It changes type of dflags to be enum gpiod_flags.

Indeed it does, so please ignore my comment then :-)