On Thu, Apr 11, 2019 at 12:58:48PM +0300, Andy Shevchenko wrote: > > > +acpi_gpiochip_parse_own_gpio(struct acpi_gpio_chip *achip, > > > + struct fwnode_handle *fwnode, > > > + const char **name, > > > + unsigned long *lflags, > > > + unsigned int *dflags) > > > > Why not "unsigned int"? Now it looks inconsistent. > > inconsistent with what part? Now you have: unsigned long *lflags unsigned int *dflags why not unsigned int *lflags unsigned int *dflags ?