Re: [libgpiod] Fix for non-const bitset_cmp operator ()

[Michael Beach <michaelb@xxxxxxxx>]

Ok, will give it a try tomorrow.

Michael

On Sat, Feb 2, 2019 at 11:46 PM Bartosz Golaszewski <brgl@xxxxxxxx> wrote:
>
> sob., 2 lut 2019 o 14:37 Michael Beach <michaelb@xxxxxxxx> napisał(a):
> >
> > Hi Bart, happy to resend, but could you confirm that
> > https://patchwork-freedesktop.readthedocs.io/en/latest/index.html is a
> > reasonable place to read about how to send a patch that patchwork can
> > digest? It's been a very long time since I've submitted a patch to a
> > mailing list, and don't want to waste anybody's time, including my
> > own.
> >
> > Michael
> >
>
> I think it's enough it you resend it with git send-email and add the
> [PATCH] tag to the subject line. Your link looks like a manual for
> patchwork maintainers.
>
> Bart
>
> > On Sat, Feb 2, 2019 at 1:04 AM Bartosz Golaszewski <brgl@xxxxxxxx> wrote:
> > >
> > > śr., 28 lis 2018 o 01:35 Michael Beach <michaelb@xxxxxxxx> napisał(a):
> > > >
> > > > Hi all, when trying to build libgpiod with clang 6.0 and libc++ I was
> > > > running into a problem with bitset_cmp in line_bulk.cpp. Clang was
> > > > complaining that the operator () defined by bitset_cmp was non-const.
> > > > Although some readings of the C++ standard allow this, it was a bit of
> > > > a grey area and generally considered to be undesirable, and has since
> > > > been fixed in C++17 (it is now required to be const) -- see
> > > > https://cplusplus.github.io/LWG/issue2542.
> > > > The following patch resolves the problem...
> > > >
> > > > diff --git a/bindings/cxx/line_bulk.cpp b/bindings/cxx/line_bulk.cpp
> > > > index c93f364..e52d33d 100644
> > > > --- a/bindings/cxx/line_bulk.cpp
> > > > +++ b/bindings/cxx/line_bulk.cpp
> > > > @@ -29,7 +29,7 @@ const ::std::map<int, int> reqtype_mapping = {
> > > >
> > > >  struct bitset_cmp
> > > >  {
> > > > -       bool operator()(const ::std::bitset<32>& lhs, const
> > > > ::std::bitset<32>& rhs)
> > > > +       bool operator()(const ::std::bitset<32>& lhs, const
> > > > ::std::bitset<32>& rhs) const
> > > >         {
> > > >                 return lhs.to_ulong() < rhs.to_ulong();
> > > >         }
> > >
> > > Hi Michael,
> > >
> > > please resend this with [PATCH][libgpiod] tags. I use patchwork and it
> > > didn't pick this one up.
> > >
> > > Bart