Re: [PATCH/RFC] pinctrl: sh-pfc: r8a7791: Fix VIN1 versioned groups

[Geert Uytterhoeven <geert@xxxxxxxxxxxxxx>]

On Fri, Jan 11, 2019 at 1:45 PM Geert Uytterhoeven
<geert+renesas@xxxxxxxxx> wrote:
> The naming of the "b" versions of the VIN1 pin groups is a bit odd, in
> that the "_b" appears in the middle of the names, instead of as a
> suffix.
>
> Increase consistency with other SoCs by making R-Car M2-W and M2-N, and
> RZ/G1M and RZ/G1N, use the recently added optional "version" argument of
> the VIN_DATA_PIN_GROUP() macro.
>
> Note that this breaks backwards compatibility with existing DTBs, but
> there are no upstream users of the "vin1_b_*" names.
>
> Fixes: 8e32c9671f84acd8 ("pinctrl: sh-pfc: r8a7791: Add VIN pins")
> Signed-off-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx>
> ---
> Is it worth making this change?
> If yes, should we retain backwards-compatibility using e.g. the patch
> below, increasing kernel size by 380 bytes?
>
> Note that unlike the deprecated "avb_mdc" pin groups on R-Car Gen3, the
> "vin1_b_*" groups never had upstream users, so I'm inclined not to care
> about backwards compatibility.

>         --- a/drivers/pinctrl/sh-pfc/sh_pfc.h
>         +++ b/drivers/pinctrl/sh-pfc/sh_pfc.h
>         @@ -67,6 +67,14 @@ struct sh_pfc_pin_group {
>                         .nr_pins = ARRAY_SIZE(n##__VA_ARGS__##_pins.data##s),   \
>                 }
>
>         +#define VIN_DATA_PIN_GROUP_ALIAS(alias, n, s, ...)                     \
>         +       {                                                               \
>         +               .name = #alias,                                         \

JFTR (everything below "---" is not meant to be included anyway):

        .name = #alias#s,                                       \

>         +               .pins = n##__VA_ARGS__##_pins.data##s,                  \
>         +               .mux = n##__VA_ARGS__##_mux.data##s,                    \
>         +               .nr_pins = ARRAY_SIZE(n##__VA_ARGS__##_pins.data##s),   \
>         +       }
>         +

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds