Re: [PATCH v2 2/2] pinctrl: sh-pfc: r8a7794: initialize TDSEL register for ES1.0

[Geert Uytterhoeven <geert@xxxxxxxxxxxxxx>]

On Mon, Jan 7, 2019 at 11:13 PM Wolfram Sang
<wsa+renesas@xxxxxxxxxxxxxxxxxxxx> wrote:
> Documentation for ES1.0 says that some bits in TDSEL must be set (ch
> 5.3.35 in R-Car E2 v0.5). However, the reset value of the register is 0,

Hardware User Manual Rev.1.10 says the values must be 00, so I assume
that manual applies to later ES versions.

> so software has to do it. Add this to the kernel driver to ensure this
> is really done independent of firmware versions and use whitelisting for
> ES versions known to need this.
>
> This is needed for some SD cards supporting SDR104 transfer mode.
>
> Signed-off-by: Wolfram Sang <wsa+renesas@xxxxxxxxxxxxxxxxxxxx>

Reviewed-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx>
i.e. will queue in sh-pfc-for-v5.1.

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds