Re: [PATCH v2 1/2] pinctrl: sh-pfc: r8a7790: initialize TDSEL register for ES1.0

[Geert Uytterhoeven <geert@xxxxxxxxxxxxxx>]

On Mon, Jan 7, 2019 at 11:13 PM Wolfram Sang
<wsa+renesas@xxxxxxxxxxxxxxxxxxxx> wrote:
> Documentation for ES1.0 says that some bits in TDSEL must be set (ch
> 5.3.39 in R-Car H2 v0.91). However, the reset value of the register is

Also in Hardware User Manual Rev.1.00.
\
> 0, so software has to do it. Add this to the kernel driver to ensure
> this is really done independent of firmware versions and use
> whitelisting for ES versions known to need this.
>
> This is needed for some SD cards supporting SDR104 transfer mode. For
> me, TDSEL was not initialized by the firmware and I had problems with
> the card when re-inserting it.
>
> Signed-off-by: Wolfram Sang <wsa+renesas@xxxxxxxxxxxxxxxxxxxx>

Reviewed-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx>
i.e. will queue in sh-pfc-for-v5.1.

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds