Re: [PATCH 2/7 v1] spi: ath79: Convert to use CS GPIO descriptors

[Linus Walleij <linus.walleij@xxxxxxxxxx>]

Hi Alban,

thanks a lot for your review!

On Mon, Dec 17, 2018 at 10:02 AM Alban <albeu@xxxxxxx> wrote:

> AFAICT this whole block can be removed.
(...)
> > +     if (!spi->cs_gpiod) {
> >               u32 cs_bit = AR71XX_SPI_IOC_CS(spi->chip_select);
> >
> >               if (spi->mode & SPI_CS_HIGH)
>
> The bitbang code already take care to properly configure CS in
> spi_bitbang_setup(), if the core now take care of the GPIO setup we can
> probably remove this whole function.
(...)
> Now if we can remove ath79_spi_setup_cs() and ath79_spi_cleanup_cs() we
> can also remove ath79_spi_setup() and directly use spi_bitbang_setup().
> That would remove quiet a bit of code, very nice!
(...)
> Here we could also remove this function and directly use
> spi_bitbang_cleanup().

I see that you spot a whole bunch of improvements/cleanups we can do
in this context, it'd be great if you could make a patch on top of this
for those things, when you have time! (I don't really dare to since I can't
test it on hardware.)

Any testing would also be greatly appreciated!

We target v4.22 for these initial SPI CS changes.

Yours,
Linus Walleij