Re: [PATCH 2/7 v1] spi: ath79: Convert to use CS GPIO descriptors

[Linus Walleij <linus.walleij@xxxxxxxxxx>]

On Mon, Dec 17, 2018 at 12:35 PM Jonathan Cameron
<jonathan.cameron@xxxxxxxxxx> wrote:

> > -     } else {
> > +     if (!spi->cs_gpiod) {
>
> It would obviously not be a minimal change, but the resulting code
> would be slightly nicer if you were to flip this to exit quickly in
> the case where we do have descriptors.
>
> u32 cs_bit;
>
> if (spi->cs_gpiod)
>         return 0;
>
> cs_bit = ...
>
> return 0;

Hm I bet we can do that as a separate cleanup if this is even still
there after all the cleanups spotted by Alban.

Yours,
Linus Walleij