Re: [gpio:devel 42/46] arch/arm/mach-omap1/board-ams-delta.c:605:10: error: too few arguments to function 'gpiochip_request_own_desc'

[Gregory CLEMENT <gregory.clement@xxxxxxxxxxx>]

Hi Linus,
 
 On lun., déc. 17 2018, Linus Walleij <linus.walleij@xxxxxxxxxx> wrote:

> On Mon, Dec 17, 2018 at 11:41 AM Gregory CLEMENT
> <gregory.clement@xxxxxxxxxxx> wrote:
>
>> >    arch/arm/mach-omap1/board-ams-delta.c: In function 'modem_assign_irq':
>> >>> arch/arm/mach-omap1/board-ams-delta.c:605:10: error: too few arguments to function 'gpiochip_request_own_desc'
>> >      gpiod = gpiochip_request_own_desc(chip, AMS_DELTA_GPIO_PIN_MODEM_IRQ,
>> >              ^~~~~~~~~~~~~~~~~~~~~~~~~
>> >    In file included from arch/arm/mach-omap1/board-ams-delta.c:14:0:
>> >    include/linux/gpio/driver.h:607:19: note: declared here
>> >     struct gpio_desc *gpiochip_request_own_desc(struct gpio_chip
>> >     *chip, u16 hwnum,
>>
>> >                       ^~~~~~~~~~~~~~~~~~~~~~~~~
>>
>> I'd like to know why I was in CC?
>
> It's because you are on Reviewed-by: on this patch.
>
> That in turn is because:
> https://marc.info/?l=linux-gpio&m=153753965704576&w=2
>
> The robots are not very intelligent and there is no way of telling
> them that you only reviewed it for MVEBU, it's another one
> of these instances of machines being pretty binary about
> things and not very intuitive.
>
> (The problem is already fixed BTW.)

Thanks for your explanation!

Gregory

>
> Yours,
> Linus Walleij

-- 
Gregory Clement, Bootlin
Embedded Linux and Kernel engineering
http://bootlin.com