Re: [gpio:devel 42/46] arch/arm/mach-omap1/board-ams-delta.c:605:10: error: too few arguments to function 'gpiochip_request_own_desc'

[Gregory CLEMENT <gregory.clement@xxxxxxxxxxx>]

Hello,
 
 On sam., déc. 15 2018, kbuild test robot <lkp@xxxxxxxxx> wrote:

> tree:   https://git.kernel.org/pub/scm/linux/kernel/git/linusw/linux-gpio.git devel
> head:   3e42f200c195fd3a39142028194b67ffaf2b5f6d
> commit: 21abf103818a4735e80fb0ab03934bed8ae9a028 [42/46] gpio: Pass a flag to gpiochip_request_own_desc()
> config: arm-omap1_defconfig (attached as .config)
> compiler: arm-linux-gnueabi-gcc (Debian 7.2.0-11) 7.2.0
> reproduce:
>         wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
>         chmod +x ~/bin/make.cross
>         git checkout 21abf103818a4735e80fb0ab03934bed8ae9a028
>         # save the attached .config to linux build tree
>         GCC_VERSION=7.2.0 make.cross ARCH=arm 
>
> All errors (new ones prefixed by >>):
>
>    arch/arm/mach-omap1/board-ams-delta.c: In function 'modem_assign_irq':
>>> arch/arm/mach-omap1/board-ams-delta.c:605:10: error: too few arguments to function 'gpiochip_request_own_desc'
>      gpiod = gpiochip_request_own_desc(chip, AMS_DELTA_GPIO_PIN_MODEM_IRQ,
>              ^~~~~~~~~~~~~~~~~~~~~~~~~
>    In file included from arch/arm/mach-omap1/board-ams-delta.c:14:0:
>    include/linux/gpio/driver.h:607:19: note: declared here
>     struct gpio_desc *gpiochip_request_own_desc(struct gpio_chip
>     *chip, u16 hwnum,

>                       ^~~~~~~~~~~~~~~~~~~~~~~~~

I'd like to know why I was in CC?

I don't remember to have ever touch this file. It's not a big deal, I
am just curious to know how my name pop-up.

Thanks,

Gregory

>
> vim +/gpiochip_request_own_desc +605 arch/arm/mach-omap1/board-ams-delta.c
>
> 0812db94 Janusz Krzysztofik 2018-09-10  595  
> 0812db94 Janusz Krzysztofik 2018-09-10  596  /*
> 0812db94 Janusz Krzysztofik 2018-09-10  597   * Obtain MODEM IRQ GPIO descriptor using its hardware pin
> 0812db94 Janusz Krzysztofik 2018-09-10  598   * number and assign related IRQ number to the MODEM port.
> 0812db94 Janusz Krzysztofik 2018-09-10  599   * Keep the GPIO descriptor open so nobody steps in.
> 0812db94 Janusz Krzysztofik 2018-09-10  600   */
> 0812db94 Janusz Krzysztofik 2018-09-10  601  static void __init modem_assign_irq(struct gpio_chip *chip)
> 0812db94 Janusz Krzysztofik 2018-09-10  602  {
> 0812db94 Janusz Krzysztofik 2018-09-10  603  	struct gpio_desc *gpiod;
> 0812db94 Janusz Krzysztofik 2018-09-10  604  
> 0812db94 Janusz Krzysztofik 2018-09-10 @605  	gpiod = gpiochip_request_own_desc(chip, AMS_DELTA_GPIO_PIN_MODEM_IRQ,
> 0812db94 Janusz Krzysztofik 2018-09-10  606  					  "modem_irq");
> 0812db94 Janusz Krzysztofik 2018-09-10  607  	if (IS_ERR(gpiod)) {
> 0812db94 Janusz Krzysztofik 2018-09-10  608  		pr_err("%s: modem IRQ GPIO request failed (%ld)\n", __func__,
> 0812db94 Janusz Krzysztofik 2018-09-10  609  		       PTR_ERR(gpiod));
> 0812db94 Janusz Krzysztofik 2018-09-10  610  	} else {
> 0812db94 Janusz Krzysztofik 2018-09-10  611  		gpiod_direction_input(gpiod);
> 0812db94 Janusz Krzysztofik 2018-09-10  612  		ams_delta_modem_ports[0].irq = gpiod_to_irq(gpiod);
> 0812db94 Janusz Krzysztofik 2018-09-10  613  	}
> 0812db94 Janusz Krzysztofik 2018-09-10  614  }
> 0812db94 Janusz Krzysztofik 2018-09-10  615  
>
> :::::: The code at line 605 was first introduced by commit
> :::::: 0812db94374867324a7811b733f95d5aa06e28b5 ARM: OMAP1: ams-delta: assign MODEM IRQ from GPIO descriptor
>
> :::::: TO: Janusz Krzysztofik <jmkrzyszt@xxxxxxxxx>
> :::::: CC: Tony Lindgren <tony@xxxxxxxxxxx>
>
> ---
> 0-DAY kernel test infrastructure                Open Source Technology Center
> https://lists.01.org/pipermail/kbuild-all                   Intel Corporation
>
>

-- 
Gregory Clement, Bootlin
Embedded Linux and Kernel engineering
http://bootlin.com