On Tue, Nov 06, 2018 at 03:47:08PM +0200, Mika Westerberg wrote: > On Tue, Nov 06, 2018 at 01:04:20PM +0200, Andy Shevchenko wrote: > > static const struct acpi_device_id cdf_pinctrl_acpi_match[] = { > > - { "INTC3001" }, > > - { } > > + { "INTC3001", (kernel_ulong_t)&cdf_soc_data }, > > + {} > > This is unrelated change and I prefer it to be { } instead of {}. Ditto > for the rest of the patches. One style vs. the other. So, I have no objection to keep your style. Will change accordingly. -- With Best Regards, Andy Shevchenko