Re: [PATCH v1 13/15] pinctrl: baytrail: Code formatting fixes

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Nov 06, 2018 at 03:52:38PM +0200, Mika Westerberg wrote:
> On Tue, Nov 06, 2018 at 01:04:32PM +0200, Andy Shevchenko wrote:
> > Replace '{ }' and remove comma from terminator line to be consistent with
> > the rest Intel SoC pin control drivers.
> >
> > Signed-off-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
> > ---
> >  drivers/pinctrl/intel/pinctrl-baytrail.c | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> > 
> > diff --git a/drivers/pinctrl/intel/pinctrl-baytrail.c b/drivers/pinctrl/intel/pinctrl-baytrail.c
> > index 6d1a43c0c251..44decdc9f07c 100644
> > --- a/drivers/pinctrl/intel/pinctrl-baytrail.c
> > +++ b/drivers/pinctrl/intel/pinctrl-baytrail.c
> > @@ -705,7 +705,7 @@ static const struct byt_pinctrl_soc_data *byt_soc_data[] = {
> >  	&byt_score_soc_data,
> >  	&byt_sus_soc_data,
> >  	&byt_ncore_soc_data,
> > -	NULL,
> > +	NULL
> 
> I prefer to have trailing "," but as discussed offline there is point
> not having it after the terminator (mainly that compiler can catch if
> someone adds an entry after it). So please update the changelog
> accordingly.

Will do, thanks!

-- 
With Best Regards,
Andy Shevchenko





[Index of Archives]     [Linux SPI]     [Linux Kernel]     [Linux ARM (vger)]     [Linux ARM MSM]     [Linux Omap]     [Linux Arm]     [Linux Tegra]     [Fedora ARM]     [Linux for Samsung SOC]     [eCos]     [Linux Fastboot]     [Gcc Help]     [Git]     [DCCP]     [IETF Announce]     [Security]     [Linux MIPS]     [Yosemite Campsites]

  Powered by Linux