On Tue, Oct 2, 2018 at 2:26 PM Timur Tabi <timur@xxxxxxxxxx> wrote: > On 10/2/18 2:38 AM, Linus Walleij wrote: > >> But as today the only driver that seems to be using valid_mask is msm, > >> so perhaps a hack is something better and then when we have a second > >> driver that requires it we figure out the real requirements. But it is > >> definately your decision;) > > Please note that MSM is supposed to be the *first* driver, not the only, > driver that needs valid_mask. So let's not make any code changes that > limit this feature to the MSM driver. I just recently encouraged Thierry to reuse this for the Tegra186 driver: https://marc.info/?l=linux-gpio&m=153787164826821&w=2 Yours, Linus Walleij