Hi Ricardo, thanks for the patch and sorry for taking time before responding. On Fri, Sep 21, 2018 at 12:36 PM Ricardo Ribalda Delgado <ricardo.ribalda@xxxxxxxxx> wrote: > GPIOs with no programmable direction are not required to implement > direction_output nor direction_input. > > If we try to set an output direction on an output-only GPIO or input > direction on an input-only GPIO simply return 0. > > This allows this single direction GPIO to be used by libgpiod. > > Signed-off-by: Ricardo Ribalda Delgado <ricardo.ribalda@xxxxxxxxx> It makes perfect sense, patch applied. I'll go in and add some comments to the code so I understand it right as well in the future. Yours, Linus Walleij