Re: [PATCH 1/3] pinctrl: mcp23s08: fix debugfs entry for mcp23s18 device

[Marco Felsch <m.felsch@xxxxxxxxxxxxxx>]

On 18-09-27 12:54, Jan Kundrát wrote:
> On čtvrtek 27. září 2018 10:55:11 CEST, Marco Felsch wrote:
> > Hi Phil,
> > 
> > On 18-09-27 09:45, Phil Reid wrote:
> > > On 26/09/2018 5:42 PM, Marco Felsch wrote:
> > > > On 18-09-26 07:55, Phil Reid wrote: ...
> > > G'day Marco,
> > > 
> > > Sorry I still don't follow.
> > > I've got a mcp23s18 in one of my systems and debugfs seems to work fine.
> > > 
> > > one_regmap_config is only used for the S08/S17 to fiddle with the
> > > name / label
> > 
> > I know, but if I read the code correctly it shouldn't work, because in
> > your case one_regmap_config is never modified, as you told. But it is
> > initialized to NULL. This confuses me a bit.
> > 
> > This tested should not be made for the MCP_TYPE_S18 case.

Hi Jan,

> 
> Ah, right. This means that the stable tree(s) need this follow-up patch from
> February, too:
> 
>  https://patchwork.ozlabs.org/patch/875045/
> 
> Thanks for catching this.

Okay, so we can drop this patch too. Can you give me some feedback for
patch "pinctrl: mcp23s08: fix irq and irqchip setup order"?

Kind regards,
Marco

> 
> With kind regards,
> Jan
> 
>