On 26/09/2018 5:42 PM, Marco Felsch wrote:
On 18-09-26 07:55, Phil Reid wrote:
G'day Marco,
On 25/09/2018 10:56 PM, Marco Felsch wrote:
This patch fixes 'commit 9b3e4207661e ("pinctrl: mcp23s08: spi: Fix regmap
debugfs entries")'. For sure the MCP23S18 device has only 1 address pin
but this will get decoded into three internally ([1], section 1.4).
[1]http://ww1.microchip.com/downloads/en/DeviceDoc/22103a.pdf
The MCP23018 (i2c) has an address pin that's decoded to 8 addresses.
The spi MCP23s18 does not from what I can see.
reference:
TABLE 1-2: SPI PINOUT DESCRIPTION (MCP23S18)
and
1.4 Multi-bit Address Decoder
The ADDR pin is used to set the slave address of the
MCP23018 (I2C only) to allow up to eight devices on
the bus using only a
So I think the original code is correct.
Sorry, mixed up different RM and the commit message isn't correct too,
shame on me.
The patch should be smaller and should not do more than one at the same
time: fixing and uniform the code. Sorry for that.
Without the patch this would ever be true, since one_regmap_config is
initialised to NULL gets only modified in case of S08/S17.
...
case MCP_TYPE_S18:
if (!one_regmap_config)
return -ENOMEM;
...
This was the fixing part. The other one is to uniform the handling and
the debugfs entries.
G'day Marco,
Sorry I still don't follow.
I've got a mcp23s18 in one of my systems and debugfs seems to work fine.
one_regmap_config is only used for the S08/S17 to fiddle with the name / label
--
Regards
Phil Reid
ElectroMagnetic Imaging Technology Pty Ltd
Development of Geophysical Instrumentation & Software
www.electromag.com.au
3 The Avenue, Midland WA 6056, AUSTRALIA
Ph: +61 8 9250 8100
Fax: +61 8 9250 7100
Email: preid@xxxxxxxxxxxxxxxxx
