On Tue, Sep 4, 2018 at 4:26 AM Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx> wrote: > This driver has no business including <linux/gpio.h>, it is a driver. > > GPIOF_DIR_IN/GPIOF_DIR_OUT are for consumers and should not be > used in drivers to use just 1/0 instead. > > Signed-off-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx> Ooops applied a similar big patch in parallel. Had to drop this one. The result should be the same. Yours, Linus Walleij