On Tue, Sep 04, 2018 at 02:26:19PM +0300, Andy Shevchenko wrote: > This driver has no business including <linux/gpio.h>, it is a driver. > > GPIOF_DIR_IN/GPIOF_DIR_OUT are for consumers and should not be > used in drivers to use just 1/0 instead. > > Signed-off-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx> Acked-by: Mika Westerberg <mika.westerberg@xxxxxxxxxxxxxxx>
Re: [PATCH v1 3/9] pinctrl: baytrail: Remove unneeded linux/gpio.h inclusion
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
- Subject: Re: [PATCH v1 3/9] pinctrl: baytrail: Remove unneeded linux/gpio.h inclusion
- From: Mika Westerberg <mika.westerberg@xxxxxxxxxxxxxxx>
- Date: Thu, 6 Sep 2018 14:22:14 +0300
- In-reply-to: <20180904112625.8630-3-andriy.shevchenko@linux.intel.com>
- Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo
- References: <20180904112625.8630-1-andriy.shevchenko@linux.intel.com> <20180904112625.8630-3-andriy.shevchenko@linux.intel.com>
- User-agent: Mutt/1.10.1 (2018-07-13)
- References:
- [PATCH v1 1/9] pinctrl: intel: Move linux/pm.h to the local header
- From: Andy Shevchenko
- [PATCH v1 3/9] pinctrl: baytrail: Remove unneeded linux/gpio.h inclusion
- From: Andy Shevchenko
- [PATCH v1 1/9] pinctrl: intel: Move linux/pm.h to the local header
- Prev by Date: Re: [PATCH v1 4/9] pinctrl: baytrail: Sort headers alphabetically
- Next by Date: Re: [PATCH v1 5/9] pinctrl: cherryview: Re-use data structures from pinctrl-intel.h
- Previous by thread: [PATCH v1 3/9] pinctrl: baytrail: Remove unneeded linux/gpio.h inclusion
- Next by thread: Re: [PATCH v1 3/9] pinctrl: baytrail: Remove unneeded linux/gpio.h inclusion
- Index(es):
 |