Re: Subject: [PATCH 00/22] gpio: xilinx: update driver to match official xilinx version

[Linus Walleij <linus.walleij@xxxxxxxxxx>]

Hi Alexander!

On Mon, Jul 23, 2018 at 8:53 AM Hedges Alexander
<ahedges@xxxxxxxxxxxxxxx> wrote:

> In general, what I did was cherry-pick all the commits from Linux-xlnx
> that we’re not in mainline Linux in the order they were made such that
> the end result is the current gpio-xilinx.c at the head of Linux-xlnx.

This approach seems to make sense if what you want to do is
minimize syntactic hamming-distance.

It may also be what makes most sens for Xilinx internal kernel
tree from a certain point of view.

But from my perspective, as community maintainer, this approach
has no real value.

What I need is patches that re-structure whatever you found in
Xilinx tree into semantic chunks that make sense from a logical
point of view. Then I will be able to provide feedback for each of
these on how to achive the same better (as I've started to do.)

So drop the idea to keep the code textually close to the Xiliinx
tree, work on a set of patches that brings over the functionality
found in the Xilinx tree, step by step, disregarding in what order
it was created or refined internally at Xilinx.

Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-gpio" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html