Re: [PATCH 01/22] Xilinx: ARM: GPIO: updated driver names for cleanup

[Michal Simek <michal.simek@xxxxxxxxxx>]

On 22.7.2018 21:17, Linus Walleij wrote:
> On Sat, Jul 21, 2018 at 4:18 PM Hedges Alexander
> <ahedges@xxxxxxxxxxxxxxx> wrote:
> 
> Hi Alex!
> 
> thanks for your patch!
> 
>> From: John Linn <john.linn@xxxxxxxxxx>
>> Date: Fri, 29 Jun 2012 11:27:45 -0700
>>
>> Driver names were changed to match the kernel.
>>
>> Signed-off-by: John Linn <john.linn@xxxxxxxxxx>
>> Signed-off-by: Alexander Hedges <ahedges@xxxxxxx>
>> (cherry picked from commit e9a98626baf3b31fa6a699576d8d089c5df10f35)
> 
> This patch is unfortunately a bit confusing for me.
> 
> - It is named ARM: something but doesn't affect the arch/arm/*
>  hierarchy. Just use gpio: xlilinx: ...
> 
> - It changes a lot of stuff all over and has a very terse commit
>   message which does not seem to have too much to do with the
>   changes made.
> 
> It looks a bit like something from a corporate tree.

These are patches which we have in Xilinx tree as you see from 2012.
Origin driver was added in 2008.
It will be the best to rewrite it to new style because this driver is
quite old.

Thanks,
Michal


--
To unsubscribe from this list: send the line "unsubscribe linux-gpio" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html