On Thu, Jun 14, 2018 at 6:45 AM, Sergio Paracuellos <sergio.paracuellos@xxxxxxxxx> wrote: > Ok, so... does the following single node sounds acceptable? > > gpio: gpio@600 { > #gpio-cells = <2>; > #interrupt-cells = <2>; > compatible = "mediatek,mt7621-gpio"; > gpio-controller; > interrupt-controller; > reg = <0x600 0x60>; > interrupt-parent = <&gic>; > interrupts = <GIC_SHARED 12 IRQ_TYPE_LEVEL_HIGH>; > mediatek,gpio-bank-widths = <32 32 32>; Why would you need this? It is pretty obvious from the compatible string isn't it? Just use that to tell that "aha, it is mediatek,mt7321-gpio, so it has 3x32 GPIOs indexed from 0..95". No need of overspecifying stuff. Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-gpio" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html