Re: [PATCH 1/4] pinctrl: mcp23s08: Do not complain about unsupported params

[Linus Walleij <linus.walleij@xxxxxxxxxx>]

On Thu, Jun 7, 2018 at 5:30 PM, Jan Kundrát <jan.kundrat@xxxxxxxxx> wrote:
> On čtvrtek 7. června 2018 3:42:49 CEST, Phil Reid wrote:
>>
>> On 26/01/2018 02:22, Jan Kundrát wrote:
>>>
>>> It is expected that some of these operations won't work on each and
>>> every HW. Previously, even a simple `cat
>>> /sys/kernel/debug/pinctrl/spi1.1/pinconf-pins` caused excessive dmesg
>>> output.
>>
>>
>> Yes it is rather excessive.
>> Could be downgraded to dev_dbg instead of removed completely?
>
>
> Let's split this into two halves, one for mcp_pinconf_get() and another one
> for mcp_pinconf_set().

It's fine to keep in one patch.

Just update to degrade to dev_dbg() in the common path.

> I can change the patch to still print out a debugging message when
> attempting to *set* some unsupported configuration. I don't see much value
> in that, but if that's what people want, I'll post an update. Should I do
> that?

Yeah that's fine.

Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-gpio" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html