On čtvrtek 7. června 2018 3:42:49 CEST, Phil Reid wrote:
On 26/01/2018 02:22, Jan Kundrát wrote:
It is expected that some of these operations won't work on each and
every HW. Previously, even a simple `cat
/sys/kernel/debug/pinctrl/spi1.1/pinconf-pins` caused excessive dmesg
output.
Yes it is rather excessive.
Could be downgraded to dev_dbg instead of removed completely?
Let's split this into two halves, one for mcp_pinconf_get() and another one
for mcp_pinconf_set().
When checking the pinconf settings, it IMHO makes sense to ask for all
possible properties. That's what the generic code in debugs is doing, after
all, and that's why a `cat /sys/kernel/debug/pinctrl/spi*/pinconf-pins`
currently prints to the kernel log. I think that this should just return
ENOTSUPP without any extra messages.
I can change the patch to still print out a debugging message when
attempting to *set* some unsupported configuration. I don't see much value
in that, but if that's what people want, I'll post an update. Should I do
that?
Cheers,
Jan
--
To unsubscribe from this list: send the line "unsubscribe linux-gpio" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
