On Thu, May 17, 2018 at 10:48:58PM +0800, Hao Zhang wrote: > 2018-05-15 19:17 GMT+08:00 Maxime Ripard <maxime.ripard@xxxxxxxxxxx>: > > Hi, > > > > On Mon, May 14, 2018 at 10:45:44PM +0800, Hao Zhang wrote: > >> 2018-02-26 17:00 GMT+08:00 Maxime Ripard <maxime.ripard@xxxxxxxxxxx>: > >> > Thanks for respinning this serie. It looks mostly good, but you still > >> > have a quite significant number of checkpatch (--strict) warnings that > >> > you should address. > >> > >> Thanks for reviews :) ,i'm sorry for that, it will be fixed next > >> time. and, besides, in what situation were the checkpatch warning > >> can be ignore？ > > > > The only one that can be reasonably be ignored is the long line > > warning, and only if complying to the limit would make it less easy to > > understand. > > > >> > > >> > On Sun, Feb 25, 2018 at 09:53:08PM +0800, hao_zhang wrote: > >> >> +#define CAPTURE_IRQ_ENABLE_REG 0x0010 > >> >> +#define CFIE(ch) BIT(ch << 1 + 1) > >> >> +#define CRIE(ch) BIT(ch << 1) > >> > > >> > You should also put your argument between parentheses here (and in all > >> > your other macros). > >> > >> Do you mean like this ? > >> #define CFIE(ch) BIT((ch) << 1 + 1) > >> #define CRIE(ch) BIT((ch) << 1) > > > > Yep, exactly. Otherwise, if you do something like CRIE(1 + 1), the > > result will be BIT(1 + 1 << 1), which will expand to 3, instead of 4. > > > > Also, CFIE looks a bit weird here, is it the offset that is > > incremented, or the value? You should probably have parentheses to > > make it explicit. > > The vallue, > BIT(((ch) << 1) + 1) It seem not very nice... > > uhmm... > In CAPTURE_IRQ_ENABLE_REG odd number is CFIE, even number is CRIE > each channel has one CFIE and CRIE. > > we can also describe like this: > #define CFIE(ch) BIT((ch) * 2 + 1) > #define CRIE(ch) BIT((ch) * 2) That works for me. Maxime -- Maxime Ripard, Bootlin (formerly Free Electrons) Embedded Linux and Kernel engineering https://bootlin.com
Attachment:
signature.asc
Description: PGP signature
