Re: [PATCH] pinctrl: cherryview: Associate IRQ descriptors to irqdomain manually

[Linus Walleij <linus.walleij@xxxxxxxxxx>]

On Wed, Apr 25, 2018 at 12:32 PM, Mika Westerberg
<mika.westerberg@xxxxxxxxxxxxxxx> wrote:

> When we dropped the custom Linux GPIO translation it resulted that the
> IRQ numbers changed slightly as well. Normally this would be fine
> because everyone is expected to use controller relative GPIO numbers and
> ACPI GpioIo/GpioInt resources. However, there is a certain set of
> Intel_Strago based Chromebooks where i8042 keyboard controller IRQ
> number is hardcoded be 182 (this is corrected with newer coreboot but
> the older ones still have the hardcoded Linux IRQ number). Because of
> this hardcoded IRQ number keyboard on those systems accidentally broke
> again.
>
> Fix this by manually associating IRQ descriptors to the chip irqdomain
> so that there are no gaps on those systems. Other systems are not
> affected.
>
> Fixes: 03c4749dd6c7 ("gpio / ACPI: Drop unnecessary ACPI GPIO to Linux GPIO translation")
> Link: https://bugzilla.kernel.org/show_bug.cgi?id=199463
> Reported-by: Sultan Alsawaf <sultanxda@xxxxxxxxx>
> Signed-off-by: Mika Westerberg <mika.westerberg@xxxxxxxxxxxxxxx>

Patch applied with Andy's ACK.

However I replaced the word "manually" with "iteratively".
I have a personal aversion for all use of the "manual" in the kernel
when it is obviously a machine doing the job, not a man.

Think of it: who is pulling the lever? A person? Not really.

It's just a machine doing the job in non-standard manner.

It evokes the old story of the zoologist, the mathematician, the statistician,
and the programmer on safari, when they suddenly spot a zebra
with no stripes.
- A unique specimen that need to be documented! The zoologist said.
- Are you sure it is not stripy on the other side? The mathematician said.
- It's not significant. The Statistician said.
- Damn it, another special case! The programmer said.

Yours,
Linus Walleij

Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-gpio" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html