Re: [PATCHv2 2/4] gpio: Remove VLA from MAX3191X driver

[Lukas Wunner <lukas@xxxxxxxxx>]

On Thu, Mar 15, 2018 at 11:00:28AM -0700, Laura Abbott wrote:
> 
> The new challenge is to remove VLAs from the kernel
> (see https://lkml.org/lkml/2018/3/7/621)
> 
> This patch replaces several a VLA with an appropriate call to
> kmalloc_array.
> 
> Signed-off-by: Laura Abbott <labbott@xxxxxxxxxx>

Reviewed-and-tested-by: Lukas Wunner <lukas@xxxxxxxxx>

This one isn't a hotpath, so the kmalloc overhead is negligible.
Did a quick test on a single-chip MAX31913 with no apparent issues.

> ---
> v2: No changes
> ---
>  drivers/gpio/gpio-max3191x.c | 7 ++++++-
>  1 file changed, 6 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/gpio/gpio-max3191x.c b/drivers/gpio/gpio-max3191x.c
> index f74b1072e84b..b5b9cb1fda50 100644
> --- a/drivers/gpio/gpio-max3191x.c
> +++ b/drivers/gpio/gpio-max3191x.c
> @@ -315,12 +315,17 @@ static void gpiod_set_array_single_value_cansleep(unsigned int ndescs,
>  						  struct gpio_desc **desc,
>  						  int value)
>  {
> -	int i, values[ndescs];
> +	int i, *values;
> +
> +	values = kmalloc_array(ndescs, sizeof(*values), GFP_KERNEL);
> +	if (!values)
> +		return;
>  
>  	for (i = 0; i < ndescs; i++)
>  		values[i] = value;
>  
>  	gpiod_set_array_value_cansleep(ndescs, desc, values);
> +	kfree(values);
>  }
>  
>  static struct gpio_descs *devm_gpiod_get_array_optional_count(
> -- 
> 2.14.3
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-gpio" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html