Hi William, Hi Linus, On 22.02.2018 21:30, William Breathitt Gray wrote: > On Thu, Feb 22, 2018 at 04:16:17PM +0100, Linus Walleij wrote: >> On Fri, Dec 29, 2017 at 9:13 PM, William Breathitt Gray >> <vilhelm.gray@xxxxxxxxx> wrote: >> >>> The ISA_BUS_API Kconfig option enables the compilation of the ISA bus >>> driver. The ISA bus driver does not perform any hardware interaction, >>> and is instead just a thin layer of software abstraction to eliminate >>> boilerplate code common to ISA-style device drivers. Since ISA_BUS_API >>> has no dependencies and does not jeopardize the integrity of the system >>> when enabled, drivers should select it when the ISA bus driver >>> functionality is needed. >>> >>> Cc: Linus Walleij <linus.walleij@xxxxxxxxxx> >>> Signed-off-by: William Breathitt Gray <vilhelm.gray@xxxxxxxxx> >> >> Patch applied to the GPIO tree for v4.17. >> >> Can you confirm that we don't have any dangling ISA >> drivers not using this? >> >> Yours, >> Linus Walleij > > Hi Linus, > > This patchset should cover all current mainline drivers depending on > ISA_BUS_API. > Thanks for merging this series! Note that gpio-winbond (CONFIG_GPIO_WINBOND) driver was originally merged using ISA_BUS_API selection as done for other ISA bus gpio drivers by this patch, then temporary switched to the previous ("depends on") style by commit 92a8046c9d952a to fix a circular Kconfig dependency. So now this commit (92...) should be reverted to make gpio-winbond driver Kconfig dependency / selection consistent with the remaining ISA bus gpio drivers. Unfortunately, I can't test the reversion myself because it looks like Linus didn't push his trees yet to git.kernel.org after applying this series (or I am not looking at the right place - linusw/linux-gpio.git?). Best regards, Maciej -- To unsubscribe from this list: send the line "unsubscribe linux-gpio" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html