Re: [PATCH] [libgpiod] tools: move function attributes to the header file

[Bartosz Golaszewski <brgl@xxxxxxxx>]

2018-02-20 19:27 GMT+01:00 Clemens Gruber <clemens.gruber@xxxxxxxxxxxx>:
> Hi Bartosz,
>
> On Tue, Feb 20, 2018 at 06:57:10PM +0100, Bartosz Golaszewski wrote:
>> 2018-02-20 17:57 GMT+01:00 Clemens Gruber <clemens.gruber@xxxxxxxxxxxx>:
>> > The attributes should be in the definition in the header file.
>> > Otherwise, the noreturn attribute seems to have no effect and GCC
>> > emits several Wimplicit-fallthrough warnings when compiling libgpiod.
>> > This patch fixes those warnings.
>> >
>> > Signed-off-by: Clemens Gruber <clemens.gruber@xxxxxxxxxxxx>
>> > ---
>> >  src/tools/tools-common.c | 6 ++----
>> >  src/tools/tools-common.h | 5 +++--
>> >  2 files changed, 5 insertions(+), 6 deletions(-)
>> >
>>
>> Hi Clemens,
>>
>> I'm not getting any warning. What GCC are you using?
>
> I am using GCC 7.3.0.
>
> I think the -Wimplicit-fallthrough warning was introduced with 7.x and
> is enabled by -Wextra.
>
> Regards,
> Clemens

Indeed. Thanks for spotting that. I applied it to master and v1.0.x.
Could you backport this patch to v0.3.x as well?

Best regards,
Bartosz Golaszewski
--
To unsubscribe from this list: send the line "unsubscribe linux-gpio" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html