2018-02-20 17:57 GMT+01:00 Clemens Gruber <clemens.gruber@xxxxxxxxxxxx>: > The attributes should be in the definition in the header file. > Otherwise, the noreturn attribute seems to have no effect and GCC > emits several Wimplicit-fallthrough warnings when compiling libgpiod. > This patch fixes those warnings. > > Signed-off-by: Clemens Gruber <clemens.gruber@xxxxxxxxxxxx> > --- > src/tools/tools-common.c | 6 ++---- > src/tools/tools-common.h | 5 +++-- > 2 files changed, 5 insertions(+), 6 deletions(-) > Hi Clemens, I'm not getting any warning. What GCC are you using? Bart -- To unsubscribe from this list: send the line "unsubscribe linux-gpio" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] [libgpiod] tools: move function attributes to the header file
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
- Subject: Re: [PATCH] [libgpiod] tools: move function attributes to the header file
- From: Bartosz Golaszewski <brgl@xxxxxxxx>
- Date: Tue, 20 Feb 2018 18:57:10 +0100
- In-reply-to: <20180220165732.26150-1-clemens.gruber@pqgruber.com>
- References: <20180220165732.26150-1-clemens.gruber@pqgruber.com>
- Follow-Ups:
- Re: [PATCH] [libgpiod] tools: move function attributes to the header file
- From: Clemens Gruber
- Re: [PATCH] [libgpiod] tools: move function attributes to the header file
- References:
- [PATCH] [libgpiod] tools: move function attributes to the header file
- From: Clemens Gruber
- [PATCH] [libgpiod] tools: move function attributes to the header file
- Prev by Date: Re: [PATCH v4 3/3] pinctrl: mcp23s08: add open drain configuration for irq output
- Next by Date: [PATCH] pinctrl: samsung: Validate alias coming from DT
- Previous by thread: [PATCH] [libgpiod] tools: move function attributes to the header file
- Next by thread: Re: [PATCH] [libgpiod] tools: move function attributes to the header file
- Index(es):
 |