Re: [PATCH v2] gpio: of: Support SPI nonstandard GPIO properties

[Geert Uytterhoeven <geert@xxxxxxxxxxxxxx>]

Hi Linus,

On Mon, Jan 8, 2018 at 3:40 PM, Linus Walleij <linus.walleij@xxxxxxxxxx> wrote:
> On Mon, Jan 8, 2018 at 2:25 PM, Geert Uytterhoeven <geert@xxxxxxxxxxxxxx> wrote:
>>> +/*
>>> + * The SPI GPIO bindings happened before we managed to establish that GPIO
>>> + * properties should be named "foo-gpios" so we have this special kludge for
>>> + * them.
>>> + */
>>> +#if IS_ENABLED(CONFIG_SPI_MASTER)
>>
>> AFAIU, Rob really meant C "if", not CPP "#ifdef", so the code path is always
>> exercised by the compiler.
>
> But that means increased code footprint for everyone and its dog no matter if

Gcc is (usually) smart enough to compile out all code inside "if (0) { ... }".

> they are using regulators or not.

s/regulators/spi/?

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds
--
To unsubscribe from this list: send the line "unsubscribe linux-gpio" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html