Re: [PATCH v2] gpio: of: Support SPI nonstandard GPIO properties

[Linus Walleij <linus.walleij@xxxxxxxxxx>]

On Mon, Jan 8, 2018 at 2:25 PM, Geert Uytterhoeven <geert@xxxxxxxxxxxxxx> wrote:

>> +/*
>> + * The SPI GPIO bindings happened before we managed to establish that GPIO
>> + * properties should be named "foo-gpios" so we have this special kludge for
>> + * them.
>> + */
>> +#if IS_ENABLED(CONFIG_SPI_MASTER)
>
> AFAIU, Rob really meant C "if", not CPP "#ifdef", so the code path is always
> exercised by the compiler.

But that means increased code footprint for everyone and its dog no matter if
they are using regulators or not.

If people think that the #ifdeffery is such a horrible ugliness I can create
gpiolib-of-spi.c and compile it conditionally and put the ifdefs for
stubs in gpiolib-of-spi.h but I just think it is a bit over the top for a single
function like this.

Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-gpio" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html