Re: [PATCH] pinctrl: sh-pfc: r8a7795: Add SATA pins, groups, and functions

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Geert,

> Reviewed-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx>
> i.e. will queue in sh-pfc-for-v4.16.

Thanks for the fast review!

> 
> > Note: To repeat the test you must:
> > a) switch pin7 from SW12 to OFF
> 
> Funny how the relation of MD12 to SATA is mentioned only in the Salvator-XS
> hardware manual, but not in the R-Car Gen3 User's Manual? Or did I miss it?

I just followed the XS manual, to be honest.

> > b) set an external GPIO to 0 by using these commands:
> >         i2cset -y 4 0x20 3 0x7f (set pin to output)
> >         i2cset -y 4 0x20 1 0x7f (set pin to 0)
> 
> Time to add the PCA9654 to the DTS, so users can use a gpio-hog instead?

Yes, I'll send some patches (with questions) in a minute. Just wanted to
check if this one is OK.

See you in a minute ;)

   Wolfram

Attachment: signature.asc
Description: PGP signature


[Index of Archives]     [Linux SPI]     [Linux Kernel]     [Linux ARM (vger)]     [Linux ARM MSM]     [Linux Omap]     [Linux Arm]     [Linux Tegra]     [Fedora ARM]     [Linux for Samsung SOC]     [eCos]     [Linux Fastboot]     [Gcc Help]     [Git]     [DCCP]     [IETF Announce]     [Security]     [Linux MIPS]     [Yosemite Campsites]

  Powered by Linux